Open LustigePerson opened 3 years ago
Thanks for tidying up the Biconda recipe @LustigePerson , I meant to intercept the auto-PR in Bioconda to make those changes, but obviously it slipped my mind!
The umap-learn pin was updated to deal with https://github.com/ebi-gene-expression-group/scanpy-scripts/issues/81, but I'm trying in the above-noted PR to unpin it. If the CI passes I have no issue with that.
I think that moving the Scanpy version below without changing the scanpy-scripts version (but only the build) will break some calls that break from 1.7.x to 1.8.0, we need to revert this in bioconda and only merge those changes on a new version of scanpy scripts, so that 0.4.x keeps pointing to 1.7.x. This will also generate a new version of the container with an important change in scanpy but without signalling it on the version, which can break some galaxy tools that make use of the 1.7.x calls.
All good, and thanks for the fix @LustigePerson, I was under the impression that the 1.0.0 release of this package hadn't happened yet, but that release had already moved to scanpy 1.8.0, so all good!
First of all,
thanks for this great project. I tried to use
scanpy-scripts
in apython 3.9
environment but could not install it. Neither withpip
nor withconda
.The problem seems to come down to
umap-learn
in the requested version<0.4.0
.As far as I can see the the also requested
scanpy
version (>1.8.0
) ist not restrictignumap-learn
anymore. Is there any specific reason to keep the version before0.4.0
?Repro-Scenario
I used the
miniforge3
docker container:This results in an
UnsatisfiableError
, which seems to be caused byumap-learn<0.4.0
, as this is the only of the requested packages that I can not install manually (see below),So the question is, does
umap-learn
has to be fixed or is the problem coming from some other package? FYI: I already udpated the conda-receipt to match the current requirements: PR 29511