search

ebi-gene-expression-group / scanpy-scripts

Scripts for using scanpy
Apache License 2.0
29 stars 13 forks source link

Release/v1.9.301 to develop #132

Closed pcm32 closed 5 months ago

pcm32 commented 5 months ago

For reviewing purposes of the release changes only.

pcm32 commented 5 months ago

Please do not merge here, I will merge in sourcetree locally and push once this is approved.

pmb59 commented 5 months ago

HI @pcm32, why do you need scipy and scikit-learn in this release?

pcm32 commented 5 months ago

It is part of the pinning done to have everything working with scanpy 1.9.x (tests passing). Those changes are part of previous reviewed PRs, what needs approval here is more the formal release part (ie. that all parts where the scanpy-scripts package version should be changed are changed, the version scheme, etc). Thanks for taking a look.

pcm32 commented 5 months ago

To be more explicit, those have always been dependencies of scanpy scripts, but latest versions broke bknn, so we had to add them explicitly with version constraints.

pcm32 commented 5 months ago

Thanks for the review @pmb59 .