1.6.0 bugfixes - Githubissues

ebi-gene-expression-group / scanpy-scripts

Scripts for using scanpy

Apache License 2.0

30 stars 13 forks source link

Closed pinin4fjords closed 4 years ago

pinin4fjords commented 4 years ago

Just some minor tweaks I discovered were necessary when I was testing release from last PR:

Cellranger option was wrong
I'd forgotten to switch the 'key_added' behaviour of the neighbors script to scanpy-native. This is neater, since the native behaviour is now more complex, writing to obsp as well as .uns.
BBKNN needed more complex behaviour to mimic the newer neighbours, dealing with the obsp slots as well as .uns.

nh3 commented 4 years ago

LGTM. Many thanks!

pinin4fjords commented 4 years ago

Thanks for review @nh3