search

ebi-pf-team / genome-properties

GNU General Public License v3.0
12 stars 12 forks source link

GenProp0145 - evidence logic #20

Closed LornaMGnify closed 6 years ago

LornaMGnify commented 7 years ago

Steps 4 and 5, which are both set to required, have the same evidence as each other for 2 of the 3 potential evidences. This seems logically wrong. The 3rd evidence in each case is specific for that step - should I remove the other two? How can I tell if this will leave the evidence TOO narrow or too specific? Also the test FASTA file for these steps was the same (presumably because one of the repeated evidences was listed first). I have changed them to be the unique evidences, but it is worth being aware of for other cases. FYI - the new FASTA info for the "unique" evidences are TREMBL - there were no SWISSPROT.

LornaMGnify commented 6 years ago

Even though it seems logically wrong it is fine - as it allows the calculation of all 3 potential paths in one property.