ebi-uniprot / QuickGoFE

Front End component for QuickGo.
1 stars 1 forks source link

with dropdown list to multiply chart size #202

Closed its-mahdi closed 3 years ago

its-mahdi commented 4 years ago

Here is the link to the ticket: https://www.ebi.ac.uk/panda/jira/browse/GOA-3503

There are a few Angular related issues here that aren't addressed yet in this PR. We may or may not want to address them as they are all minor.

  1. I wasn't able to normally update the scope when a selection was made in the dropdown list, but managed to find a way to pass it to the function that I needed via function arguments. You can see the code here: https://github.com/ebi-uniprot/QuickGoFE/blob/chart-options-input-field/app/directives/chart.html#L19

  2. I also wasn't able to have a default selection using ng-init for the list, therefore, nothing is selected by default and there seem to be an empty option added to the list too: https://github.com/ebi-uniprot/QuickGoFE/blob/chart-options-input-field/app/directives/chart.html#L20