ebi-webcomponents / nightingale

Data visualisation web components for the life sciences.
https://ebi-webcomponents.github.io/nightingale
MIT License
118 stars 38 forks source link

Feat/nightingale tooltip #289

Open justintyf01 opened 2 months ago

justintyf01 commented 2 months ago

I am using this nightingale library for antibody sequence visualisation and it was missing a tooltip component. I have implemented this component, feel free to use it if deemed useful.

Thank you.

netlify[bot] commented 2 months ago

Deploy Preview for cozy-marzipan-abb3b4 ready!

Name Link
Latest commit dbb93d3b3b8d13558bcd5a9ef8c85cfcef646a82
Latest deploy log https://app.netlify.com/sites/cozy-marzipan-abb3b4/deploys/668cf6576fcdb70008af5d23
Deploy Preview https://deploy-preview-289--cozy-marzipan-abb3b4.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

gustavo-salazar commented 1 month ago

Dear @justintyf01 Thank you so much for opening this PR, and sorry for taking this long to reply. And yeah, a tooltip is something other users have requested. So, I'll happily include a component that offers that into Nightingale. I will check this PR soon but I'll ask you 2 things before:

  1. The formatting on your side uses 4 spaces, and maybe other options that are making the read of your changes a harder than needed. I have run npm run format on main, so please do the same on your branch, after merging the latest changes from main. Hopefully. this will make the PR to only show the important changes.
  2. Please create a story in /stories so we can see an example of the tooltip in the demo app.