search

ebi-webcomponents / nightingale

Data visualisation web components for the life sciences.
https://ebi-webcomponents.github.io/nightingale
MIT License
121 stars 38 forks source link

Nightingale sequence heatmap update to v1 #290

Closed marcelo-q closed 2 months ago

marcelo-q commented 4 months ago

Hello. The PDBe heatmap-component has been recently updated to it’s first stable version (1.0) and I’ve been asked to update the Nightingale Sequence Heatmap component to reflect this.

These are mostly minor fixes that do not affect what was previously discussed and adjusted in the first PR.

Perhaps the biggest change is the introduction of an attributed named "hm-highlight-width" to control the border width of the heatmap highlight.

Please let me know if there is anything requiring adjustment and I will be glad to reply and fix it

netlify[bot] commented 4 months ago

Deploy Preview for cozy-marzipan-abb3b4 ready!

Name Link
Latest commit ed131c12f2a5ece28bee52ec66ca7c7c2da6a49d
Latest deploy log https://app.netlify.com/sites/cozy-marzipan-abb3b4/deploys/66c4a67e075d1100086fffd7
Deploy Preview https://deploy-preview-290--cozy-marzipan-abb3b4.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

gustavo-salazar commented 2 months ago

Hey thanks for the changes. before I merge, do you mind solving the conflict with main, I think it's because I ran prettier on the main branch after you have branch out