ebi-webcomponents / protvista-uniprot

The ProtVista tool for the UniProt website
MIT License
12 stars 6 forks source link

Add mutagenesis #31

Closed xwatkins closed 3 years ago

xwatkins commented 3 years ago

Reference to existing issue

Description of changes

Testing/Styleguide

xwatkins commented 3 years ago

Looks good. Function-wise it's working as expected 👍🏽

Fixed an error I found, and moved a bit of the logic around to fix linting and types, so please do have an other look and check that I haven't broken something unexpectedly.

Also, I've proposed a different approach for data loading, but haven't pushed code related to it as it might need further discussion. See related inline comment. This is the only bit that I think might need a change.

Also made a couple of changes after noticing a bug. I had considered using Promise.all but discarded it because of the "fail fast" approach but if there are potential performance improvements thanks to parallelisation happy to give it a go.