Closed reva closed 3 years ago
I like this change to open up this enum! I found a few places which call .toString()
on the OrderType
(now EbicsOrderType
)
eg lines like orderType = EbicsXmlFactory.createOrderType(type.toString());
need to be changed to orderType = EbicsXmlFactory.createOrderType(type.getCode());
@uwemaurer Thanks for the quick feedback! Should be fixed now. Is there a release process for this library?
Thank you for your change. There is currently no release process. I suggest to use a version built on JitPack with a specific commit. Having proper releases would be good, I am planning to do this in the future.
The
OrderType
is actually not a fixed set but has bank specific codes as well. e.g. Credit Suisse in Switzerland hasXTD
for their test environment. There even seems to be some standardisation around Switzerland specific codes: https://www.six-group.com/dam/download/banking-services/interbank-clearing/en/standardization/ebics/ebics.pdf.I suggest opening up the 'OrderType' to be able to set any order code in the future. This change should be completely backwards compatible.