search

ebidel / filer.js

A wrapper library for the HTML5 Filesystem API what reuses UNIX commands (cp, mv, ls) for its API.
Other
1.49k stars 155 forks source link

Filer.prototype.df method is missing in bower build (@version 0.4.2) #37

Closed shabunc closed 11 years ago

shabunc commented 11 years ago

It looks like there's a problem with tagging policy, but I'm not totally sure.

Problem: filer.js installed through bower and filer.js cloned as git repo differs, though share the save build number.

Steps to reproduce:

  1. git clone https://github.com/ebidel/filer.js.git
  2. bower install filer.js
  3. vimdiff app/bower_components/filer.js/src/filer.js filer.js/src/filer.js

\ What I expect to see:** I expect to have whether two equal files whether two different files with different build numbers.

What I actually see: I that that in bower version Filer.prototype.df method is missing, though both files share the same build number (0.4.2, to be precise)

Details: bower version in 1.2.6, but it does not look like something bower-specific.

ebidel commented 11 years ago

The bower packaged wasn't updated. Fixed in https://github.com/ebidel/filer.js/commit/17e6de69e06c61ba1c92d975378a46ad8f6995fa

shabunc commented 11 years ago

nice! thanks!

shabunc commented 11 years ago

Hm, but wait, if only this has been the reason, why build numbers does not differed?

ebidel commented 11 years ago

I had forgotten to create a release as well. Bower works on git tags.