search

ebidel / filer.js

A wrapper library for the HTML5 Filesystem API what reuses UNIX commands (cp, mv, ls) for its API.
Other
1.49k stars 155 forks source link

filer.open should not ignore onError #39

Open shabunc opened 11 years ago

shabunc commented 11 years ago

Hi there, Eric!

I just believe that filer.open should not ignore second param, onError (just as it claimed in docs). Here's a small fix for this.

If this was intentional or this pull request is inappropriate for some other reason, please, just let all of us know (by "us" I mean the community as a whole ))). If for some reasons this PR should be somehow improve, I'll be glad to fix all that needed.

It's just that, from my practise, it is almost always better to create issue and a pull request than only issue. Especially when it looks like you are talking about bug, not some new functionality :)

luv2code commented 11 years ago

Thanks for fixing this.

shabunc commented 10 years ago

Oh, I've been on my vacation and now I'm glad to be back. I'll fix code style and check out the tests. If needed, will add news. Just give me a couple of days )