search

ebidel / filer.js

A wrapper library for the HTML5 Filesystem API what reuses UNIX commands (cp, mv, ls) for its API.
Other
1.49k stars 155 forks source link

Added the qunit submodule with a .gitmodules file. #45

Closed bennlich closed 10 years ago

bennlich commented 10 years ago

It seems like tests/qunit was meant to be a submodule, but there wasn't a .gitmodules file to go with it, so I was having trouble initializing the module.

bennlich commented 10 years ago

Woops. Looks like I'm wrong. Are you somehow pointing to https://code.google.com/p/jqueryjs/source/browse/trunk/qunit/?r=6612#qunit?

bennlich commented 10 years ago

Nope! Wrong again. Tests worked with the latest version from http://qunitjs.com/, but I'm not sure how they're intended to be linked to this repo.

ebidel commented 10 years ago

It's intended to be a submodule. What to reopen this?

bennlich commented 10 years ago

Ah, okay. I couldn't find qunit.js in the repo though: https://github.com/jquery/qunit. Looks like there'd have to be a build step for qunit itself? Maybe worth just adding the two files you use instead? Let me know what you think.

On Fri, Jan 24, 2014 at 9:36 AM, Eric Bidelman notifications@github.comwrote:

It's intended to be a submodule. What to reopen this?

— Reply to this email directly or view it on GitHubhttps://github.com/ebidel/filer.js/pull/45#issuecomment-33243825 .

ebidel commented 10 years ago

Grrr, you're right. Looks like they moved to Bower and changed things around a bit. Disregard me. Mind filing a bug to track getting that into this repo?

On Fri, Jan 24, 2014 at 9:45 AM, Benny Lichtner notifications@github.comwrote:

Ah, okay. I couldn't find qunit.js in the repo though: https://github.com/jquery/qunit. Looks like there'd have to be a build step for qunit itself? Maybe worth just adding the two files you use instead? Let me know what you think.

On Fri, Jan 24, 2014 at 9:36 AM, Eric Bidelman notifications@github.comwrote:

It's intended to be a submodule. What to reopen this?

— Reply to this email directly or view it on GitHub< https://github.com/ebidel/filer.js/pull/45#issuecomment-33243825> .

— Reply to this email directly or view it on GitHubhttps://github.com/ebidel/filer.js/pull/45#issuecomment-33244498 .