Use multi observers to guard against undefined's during config phase

ebidel / geo-location

Web component element for the Geolocation API

86 stars 25 forks source link

Closed kaste closed 8 years ago

kaste commented 8 years ago

Use multi (complex) observers to guard against undefined's during config phase.
No need call fetch() in ready(), via observers you call fetch as soon as possible. ready() is always after that.
Don't see the use case for the fetching_-lock.

(Sorry I cannot test this change, since I'm not using this element.)

kolarski commented 8 years ago

@kaste It works great in my tests of the element. I'm going to close my previous PR (https://github.com/ebidel/geo-location/pull/15) in favour of this.

ebidel commented 8 years ago

LGTM