ebidel / geo-location

Web component element for the Geolocation API
https://webcomponents.org/element/ebidel/geo-location
86 stars 25 forks source link

Upgrade to Polymer 2.x #24

Closed FluorescentHallucinogen closed 7 years ago

FluorescentHallucinogen commented 7 years ago

@ebidel Please update this web component to Polymer 2.x support.

ebidel commented 7 years ago

I'm not planning to update this component with newer versions of Polymer. Pull requests welcome though :)

motss commented 7 years ago

OK. Totes interested in working the PR. 😸

sheideman commented 7 years ago

I just upgraded the element to 2.0 and it preliminarily is working, but I want to do some cross device/browser tests. I will do a PR in the next day or two. 👍

ebidel commented 7 years ago

Thanks!

On Tue, Jun 6, 2017, 6:29 PM Steve Heideman notifications@github.com wrote:

I just upgraded the element to 2.0 and it preliminarily is working, but I want to do some cross device/browser tests. I will do a PR in the next day or two. 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ebidel/geo-location/issues/24#issuecomment-306659925, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOigBXKJuiALjvbZUjEywN6GdERt7tUks5sBfz0gaJpZM4NtU-T .

paales commented 7 years ago

@sheideman Your updated version is not public?

FluorescentHallucinogen commented 7 years ago

@paales See #25.

paales commented 7 years ago

Ohhh! I can't wait!

Oupsla commented 7 years ago

Any news guys ?

ebidel commented 7 years ago

https://github.com/ebidel/geo-location/pull/25 was closed by the author. If anyone else wants to pick it back up and re-submit, I'm happy to take a look.

FluorescentHallucinogen commented 7 years ago

What an open source!.. I'll send a pull request as soon as I have some free time. :wink:

FluorescentHallucinogen commented 7 years ago

See #27. :wink:

FluorescentHallucinogen commented 7 years ago

Fixed by merging #27.