search

ebidel / i18n-msg

Polymer element for i18n string replacement
https://ebidel.github.io/i18n-msg/
63 stars 21 forks source link

Add i18n-msg-behavior #34

Closed RoXuS closed 8 years ago

RoXuS commented 8 years ago

As we have discussed in #27, i18n-msg + i18n-msg-behavior, 100% functional tests and demo. I added a i18n-page-example example to show the implementation of behavior in a component.

RoXuS commented 8 years ago

@ebidel, thx for your comments, it is fixed. About your last comment, by default, I filled the i18n property with all the keys of the first locale file. If we want use only few properties, we can override it in the child component. (See https://github.com/ebidel/i18n-msg/pull/34/commits/b85dd46f1d9d1cdefa931daa71cc8a0f04bc5507).

ebidel commented 8 years ago

We're close! Should we add a few new tests to cover this change?

RoXuS commented 8 years ago

Yes, I do that

ebidel commented 8 years ago

LGTM