search

ebidel / idb.filesystem.js

HTML5 Filesystem API polyfill using IndexedDB
https://www.npmjs.com/package/idb.filesystem.js
Other
487 stars 46 forks source link

Fix optional "options" parameter #16

Closed gwynjudd closed 11 years ago

gwynjudd commented 11 years ago

This just fixes issue #15

gwynjudd commented 11 years ago

Obviously, this is the first time I've used github. I don't think I did this quite right. I thought this was supposed to be just the "options" change

ebidel commented 11 years ago

Curious! Did you fork Swebmaster's fork? I haven't merged his changes yet, so no idea how you got to this state.

Can you do a fresh fork of my repo (https://github.com/ebidel/idb.filesystem.js), reapply just your commits, push those, and submit a pull request again?

gwynjudd commented 11 years ago

How I got into this state:

  1. I forked your repo
  2. made some changes locally and pushed
  3. merged Sebmaster's changes
  4. made some more changes locally and pushed
  5. then I did the pull request

I think I should have been doing the pull request from a branch that only included the changes that are related to this issue

ebidel commented 11 years ago

Leave off 3. Just make your changes and submit a PR for them. I'll worry about merging other people's PRs :)

Thanks again.

On Mon, Jun 10, 2013 at 9:00 PM, Gwyn Judd notifications@github.com wrote:

How I got into this state:

  1. I forked your repo
  2. made some changes locally and pushed
  3. merged Sebmaster's changes
  4. made some more changes locally and pushed
  5. then I did the pull request

I think I should have been doing the pull request from a branch that only included the changes that are related to this issue

— Reply to this email directly or view it on GitHubhttps://github.com/ebidel/idb.filesystem.js/pull/16#issuecomment-19241525 .

ebidel commented 11 years ago

Closing this in favor of your other PRS :)

gwynjudd commented 11 years ago

Sounds good to me