ebidel / idb.filesystem.js

HTML5 Filesystem API polyfill using IndexedDB
https://www.npmjs.com/package/idb.filesystem.js
Other
488 stars 46 forks source link

iOS/Safari support, resolveLocalFileSystemURL, allow debugging in Chrome #31

Closed mudcube closed 9 years ago

mudcube commented 10 years ago

btw, main page should be updated with:

Firefox 11+ Safari 7.1+ iOS 8+ Opera 15+ IE 10+

(NOTE: I tested Opera 24 but not 15, theoretically it should work on Opera 15 but could not find a copy online. I've tested on all the other browsers mentioned above.)

ebidel commented 9 years ago

Tests please :)

mudcube commented 9 years ago

No problemo. On the requested tests, were you thinking about for 'resolveLocalFileSystemURL' or another thing in mind as well? I haven't messed with quint before, so will take a look soon.

ebidel commented 9 years ago

resolveLocalFileSystemURL, the Base* methods, and support methods if you can.

mudcube commented 9 years ago

Ok, I added some tests for resolveLocalFileSystemURL, and the Base64 test from Filer.js. I'm not sure how to test whether the support method works properly, because it's the test itself--thoughts on that?

mudcube commented 9 years ago

Oh, I removed the new Date() in effort to address what you mentioned on Jan 13th:

"Not sure how I feel about adding the artificial new Date()"

Do you think it'd be best to keep the artificial date? That'd be my preference.

ebidel commented 9 years ago

Doh. Sorry about that. I was only reviewing the latest commits. That's my bad for not getting to the PR sooner.

LGTM.