ebiguy / RespeQt

RespeQt Atari serial peripheral emulator
GNU General Public License v2.0
31 stars 16 forks source link

revert last changes #34

Closed TheMontezuma closed 8 years ago

TheMontezuma commented 8 years ago

Revert changes, because baudrate settings are not relevant to a virtual serial port driver

Today HIAS asked me to check if the virtual serial port driver is affected by the baudrate settings. I realized that this is not the case for a Bluetooth connection. So I would like to revert my changes.

jzatarski commented 8 years ago

does this completely and exclusively undo the last pull request #33? if so, I can make this change by reverting the git to the previous commit, rather than merging the revert (which produces unnecessary commits, sort of like a double negative)

jzatarski commented 8 years ago

see #35, does this correct the issue?

TheMontezuma commented 8 years ago

Hi Joe, if you only know a way to revert the git to the previous commit, then it would be great. Sorry for problems. Thanks Marcin

Am 21.07.2016 um 20:27 schrieb jzatarski:

does this completely and exclusively undo the last pull request #33 https://github.com/jzatarski/RespeQt/pull/33? if so, I can make this change by reverting the git to the previous commit, rather than merging the revert (which produces unnecessary commits, sort of like a double negative)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jzatarski/RespeQt/pull/34#issuecomment-234341441, or mute the thread https://github.com/notifications/unsubscribe-auth/ANd8BKRT_kRbtVUoROn2uNtQw-sf6Fyqks5qX7oagaJpZM4JR_XH.

jzatarski commented 8 years ago

OK, I think I have corrected and reverted to the previous commit. You may have to revert on your end as well. I used the commands:

git reset --hard f7c3de543c16d27c833ff68a1a8f87a9b3c05a2f git push origin HEAD --force

The big hash-thing in the first command should be the previous commit where everything was good, which can be found with git log. Confirm your changes are correct before you force the push to your github repo.

And don't worry about causing problems: this is why we have releases, and then we have the current HEAD :)