search

ebiguy / RespeQt

RespeQt Atari serial peripheral emulator
GNU General Public License v2.0
31 stars 16 forks source link

OS X build crashes on exit #39

Closed josch1710 closed 8 years ago

josch1710 commented 8 years ago

When I close RespeQt on OSX, I get a crash dialog from the os. I run it on OS X 10.11 (El Capitan).

josch1710 commented 8 years ago

Well, it crashed. But now it don't. Scratching my heading, I close this for now.

jzatarski commented 8 years ago

sometimes crashes can be caused by certain conditions, maybe you had the options dialog or a logging dialog open when you closed it? this has caused issues on windows in the past, though I fixed it by ensuring any dialogs were closed before the main application exited.

Found the commit, 5983aa8 , seems it was diskeditdialogs that needed to be closed before exit.

blind commented 8 years ago

I fixed a crash like this on the blind-fixes branch. It seems the MainWindow::closeEvent is called twice when the application is quitting. That caused a double release of some windows. See https://github.com/blind/RespeQt/commit/69548b1551e1423ecd81e512c37e9534616e3c5a

blind commented 8 years ago

My "fix" only removes the crash though, the method is still called twice, I don't know why.