NetBSD/earmv6hf spidermonkey,firefox52 failed with bogus ARM_ARCH during autoconf

ebijun commented 5 years ago

firefox-52.9.0esr/build/autoconf/arch.m4

AC_MSG_CHECKING(ARM version support in compiler) dnl Determine the target ARM architecture (5 for ARMv5, v5T, v5E, etc.; 6 for ARMv6, v6K, etc.)

ARM_ARCH=6

ebijun commented 5 years ago

https://twitter.com/ebijun/status/1081686661069602816

ebijun commented 5 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=950261 http://mail-index.netbsd.org/port-arm/2019/01/09/msg005374.html

ebijun commented 5 years ago

https://musl.openwall.narkive.com/XpMehLZD/patch-arm-respect-both-arm-arch-6kz-and-arm-arch-6zk-macros 6KZ is the correct form, 6ZK is a gcc specific historical typo. Respect both for the widest compatibility with clang and older versions of gcc.

ebijun commented 5 years ago

grep -v 6ZK すればいいのか試す。

ebijun commented 5 years ago

実際にどう使われているのか。6KZになったとして、正しく使われるのか。

ebijun commented 5 years ago

--- ./work.earmv6hf/seamonkey-2.49.4/mozilla/build/autoconf/arch.m4.org 2019-04-05 05:06:20.469148320 +0900 +++ ./work.earmv6hf/seamonkey-2.49.4/mozilla/build/autoconf/arch.m4 2019-04-05 05:06:35.363054191 +0900 @@ -217,7 +217,7 @@

AC_MSG_CHECKING(ARM version support in compiler) dnl Determine the target ARM architecture (5 for ARMv5, v5T, v5E, etc.; 6 for ARMv6, v6K, etc.)

ARM_ARCH=${CC-cc} ${CFLAGS} -dM -E - < /dev/null | sed -n 's/.*__ARM_ARCH_$[[0-9]][[0-9]]*$.*/\1/p'
ARM_ARCH=${CC-cc} ${CFLAGS} -dM -E - < /dev/null | sed -n 's/.*__ARM_ARCH_$[[0-9]][[0-9]]*$.*/\1/p'|grep -v 6ZK AC_MSG_RESULT("$ARM_ARCH")

AC_MSG_CHECKING(for ARM NEON support in compiler)

ebijun / NetBSD

NetBSD/earmv6hf spidermonkey,firefox52 failed with bogus ARM_ARCH during autoconf #116