search

ebiwd / EBI-Framework

The EMBL-EBI Visual Framework for websites and services.
https://www.ebi.ac.uk/style-lab/websites/
19 stars 16 forks source link

Foundation 6.6 #161

Open jamesamcl opened 4 years ago

jamesamcl commented 4 years ago

Hi, are there any plans to upgrade to the latest version of Foundation? The version currently used by the EBI framework is missing some useful features such as the -order-* classes.

khawkins98 commented 4 years ago

We're currently on 6.5.3 (latest of 6.5 series). It doesn't look like 6.6 has introduced any breaking changes? https://github.com/foundation/foundation-sites/releases/tag/v6.6.0

I'll try updating and see if anything obvious explodes, would need some "community" testing from EBI-ers like you, too.

Also just a reminder that the VF 1.x series is nearing the end of support and we'll soon have the documentation in place to start advocating the adoption of VF 2.x -- more to come there soon.

jamesamcl commented 4 years ago

Ah, I thought it was 6.3.1? I am using this CSS file:

https://ebi.emblstatic.net/web_guidelines/EBI-Framework/v1.3/css/ebi-global.css

So far I've noticed that the XY grid and the source ordering classes seem to be missing. Do I need to include something else to get the full Foundation 6.5?

jamesamcl commented 4 years ago

VF 2.x sounds exciting! Is there something I can try out already?

khawkins98 commented 4 years ago

Hi again.

This is addressed in https://github.com/ebiwd/EBI-Framework/commit/dcc498aaf5203b041a207ee81a3abd359dcfc87c

Want to have a test at https://dev.ebi.emblstatic.net/web_guidelines/EBI-Framework/v1.3/css/ebi-global.min.css ?

We'll also investigate and if it seems OK we'll push to prod and npm.

On VF 2.0, glad you're interested! We're working on some better documentation for it — should hopefully be there by the end of the month, will update here again.