search

ebiwd / EBI-Pattern-library

Please head to the new pattern library:
http://www.ebi.ac.uk/style-lab/websites/patterns/
2 stars 2 forks source link

fontpresentation.js is adding inner styles into html #15

Closed nbuso closed 7 years ago

nbuso commented 7 years ago

Hii,

this file: http://ebiwd.github.io/EBI-Framework/js/fontpresentation.js is adding inner styles in the html breaking our pages.

is this script meant to be included in our html? or is it meant to be used in specific contexts?

khawkins98 commented 7 years ago

Hi, is the page that's having problems available publicly, or can you show some details of what's happening?

You don't have to use the fonts js, but obviously we'd like to track down any conflicts.

nbuso commented 7 years ago

No unfortunately I'm working locally to update to the new visual framework and is not public. In any case the problematic for now is: input { display: none; } obviously I need to override it everywhere I need an input

khawkins98 commented 7 years ago

Actually, just remove fontpresentation.js

This file wasn't meant to be included and wasn't included in most examples, but did make into the auto migration script.

Sorry for the confusion, but thanks for the heads up.