search

ebizmarts / magento2-mandrill

Mandrill integration for Magento 2.
https://mandrill.com/
36 stars 36 forks source link

Improve Email Test controller #103

Closed ihor-sviziev closed 5 years ago

ihor-sviziev commented 5 years ago

List of changes

This PR fixes following issue: https://github.com/ebizmarts/magento2-mandrill/pull/102/files#r266489766

centerax commented 5 years ago

From https://devdocs.magento.com/guides/v2.3/coding-standards/technical-guidelines.html

2.7. All non-public properties and methods SHOULD be private.

ihor-sviziev commented 5 years ago

Hi @centerax, I said the same in https://github.com/ebizmarts/magento2-mandrill/pull/102/files#r266489766, but looks like this repo has different rules

centerax commented 5 years ago

I dont agree. We should follow Magento guidelines @gonzaloebiz