search

ebizmarts / magento2-mandrill

Mandrill integration for Magento 2.
https://mandrill.com/
36 stars 36 forks source link

Define API key as sensitive/system-specific configuration #57

Closed nicobatty closed 6 years ago

nicobatty commented 6 years ago

Magento 2.2 introduced the notion of sensitive/system-specific configuration.

Considering that the Mandrill API Key is both sensitive and system-specific, I think it is safe to define it as sensitive following the Magento 2 configuration guidelines.

I haven't tested it on previous version of Magento 2 but I guess the DI configuration will simply be ignored on those versions.