search

ebkalderon / renderdoc-rs

RenderDoc application bindings for Rust
Apache License 2.0
45 stars 6 forks source link

LICENSE files in package subdirs #121

Closed schwa423 closed 2 years ago

schwa423 commented 2 years ago

Background:

Hello, the Fuchsia project vendors crates from crates.io, and in order to do so we require explicit license files alongside the source code. Here is the policy: https://fuchsia.dev/fuchsia-src/contribute/governance/policy/open-source-licensing-policies?hl=en#licenses_and_tracking . In particular, reading the SPDX package/license field from the crate's Cargo.toml is not good enough.

Request:

Could you please add LICENSE-* files to the package subdirectories, specifically renderdoc-sys/ (although you might as well do it for all package dirs that are uploaded to crates.io)?

We are currently using renderdoc-sys 0.7.1. Since crates.io doesn't allow re-uploading the same version with a modified crate, it seems the right thing to do is to upload new a new crate with version 0.7.2.

I'd appreciate if you're able to do this, since I have to file similar issues for many other crate dependencies. But if you don't have the bandwidth to address this issue, please let me know and I'll find time to submit a pull request (although of course I won't be able to upload anything to crates.io)

ebkalderon commented 2 years ago

Sorry for the delayed response! I've created and merged PR #123 and will be publishing an updated release to crates.io very soon.

schwa423 commented 2 years ago

Sorry for the more delayed response! Thanks for helping out :-)