ebkalderon / renderdoc-rs

RenderDoc application bindings for Rust
Apache License 2.0
45 stars 6 forks source link

Does not build on Windows #60

Closed retep998 closed 5 years ago

retep998 commented 5 years ago
   Compiling renderdoc v0.6.0
error[E0412]: cannot find type `ComPtr` in this scope
  --> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\renderdoc-0.6.0\src\handles.rs:44:11
   |
44 | impl From<ComPtr<winapi::um::d3d11::ID3D11Device>> for DevicePointer {
   |           ^^^^^^ not found in this scope
help: possible candidate is found in another module, you can import it into scope
   |
3  | use wio::com::ComPtr;
   |
error[E0412]: cannot find type `ComPtr` in this scope
  --> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\renderdoc-0.6.0\src\handles.rs:45:18
   |
45 |     fn from(ctx: ComPtr<winapi::um::d3d11::ID3D11Device>) -> Self {
   |                  ^^^^^^ not found in this scope
help: possible candidate is found in another module, you can import it into scope
   |
3  | use wio::com::ComPtr;
   |
error[E0412]: cannot find type `ComPtr` in this scope
  --> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\renderdoc-0.6.0\src\handles.rs:58:11
   |
58 | impl From<ComPtr<winapi::um::d3d12::ID3D12Device>> for DevicePointer {
   |           ^^^^^^ not found in this scope
help: possible candidate is found in another module, you can import it into scope
   |
3  | use wio::com::ComPtr;
   |
   Compiling wasmer-wasi v0.6.0
error[E0412]: cannot find type `ComPtr` in this scope
  --> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\renderdoc-0.6.0\src\handles.rs:59:18
   |
59 |     fn from(ctx: ComPtr<winapi::um::d3d12::ID3D12Device>) -> Self {
   |                  ^^^^^^ not found in this scope
help: possible candidate is found in another module, you can import it into scope
   |
3  | use wio::com::ComPtr;
   |
error[E0119]: conflicting implementations of trait `std::convert::From<[type error]>` for type `handles::DevicePointer`:
  --> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\renderdoc-0.6.0\src\handles.rs:51:1
   |
44 | impl From<ComPtr<winapi::um::d3d11::ID3D11Device>> for DevicePointer {
   | -------------------------------------------------------------------- first implementation here
...
51 | impl From<*mut winapi::um::d3d12::ID3D12Device> for DevicePointer {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `handles::DevicePointer`
error[E0119]: conflicting implementations of trait `std::convert::From<[type error]>` for type `handles::DevicePointer`:
  --> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\renderdoc-0.6.0\src\handles.rs:65:1
   |
44 | impl From<ComPtr<winapi::um::d3d11::ID3D11Device>> for DevicePointer {
   | -------------------------------------------------------------------- first implementation here
...
65 | impl<'a, T: glutin::ContextCurrentState> From<&'a glutin::Context<T>> for DevicePointer {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `handles::DevicePointer`
ebkalderon commented 5 years ago

Hey, nice to see you here, @retep998! That's a good catch. I admit to not yet have Windows builds set up in CI yet, which probably would've caught this issue early. I'll fix this up and open a PR right away.

ebkalderon commented 5 years ago

@retep998 Okay, I've just pushed up version 0.7.0 to Crates.io! I had some other fixes and improvements lined up for deployment anyway. Thanks for the bug report; I'll make sure to set up a Windows CI pipeline sometime soon.