Closed ralpha closed 3 years ago
@ebkalderon Could you please merge this PR and publish a new version on crates.io. This way the repo is kept maintained and up to date for a bit longer, thanks.
I updated the PR:
master
are now merged.Cargo.lock
as this should be included in the repo to make builds reproducible.Cargo.lock
Hopefully there can be a new release after this (and maybe other) PR's are merged so I can resolve other dependence conflicts in my repo downstream.
Thanks for rebasing and updating the PR! Yeah, I'll be pushing a new release as soon as the backlog of other pulls requests is properly tended to.
One small matter to note, though, is that standard Rust library crates tend to usually not check in the Cargo.lock
into version control. This is an intentional decision on the part of the Cargo developers. See https://github.com/rust-lang/cargo/issues/315 for the original reasoning behind this.
One small matter to note, though, is that standard Rust library crates tend to usually not check in the
Cargo.lock
into version control. This is an intentional decision on the part of the Cargo developers. See rust-lang/cargo#315 for the original reasoning behind this.
Yeah you are right, did not notice/know this before, learned something :) It is also in the docs: https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html and https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries
Removed the commit/lock file from the repo and history. Other changes are the same (except for lock file changes)
No worries! Thanks so much for the pack of updates, and especially for updating the CHANGELOG
as part of the PR. 🚀 I'll be preparing a new release to Crates.io shortly, though I might wait a bit for the author of #244 to respond before doing so, since it seems rather critical.
Info
This PR changes:
1.41.0
to1.45.0
lsp-types
from0.82
to0.89
tokio
from0.2
to1.4.0
tokio-util
from0.3
to0.6.5
bytes
from0.5
to1.0.1
dashmap
from3.5.1
to4.0.2
nom
from5.1
to6.1.2
env_logger
from0.7
to0.8.3
(dev-dependencies)tower-test
from0.3
to0.4
(dev-dependencies) This PR does not add any new features.Because of changes in dependencies this version needs to be a minor version update, so
0.14.0
. These changes where tested (and succeeded) on:cargo test --all
(1.51.0, 2021-03-23)cargo +nightly test --all
(1.53.0, 2021-03-24 )cargo build
(1.51.0, 2021-03-23)cargo +nightly build
(1.53.0, 2021-03-24 )This PR has effect on other PR's and issues:
Extra info
Clippy warning was not fixed so only version updates and necessary changes are in PR.
Crate checked with:
cargo +nightly udeps
=> "All deps seem to have been used."cargo audit
=> "Success No vulnerable packages found"cargo outdated
=> "All dependencies are up to date, yay!" (2021-04-08)