ebkalderon / tower-lsp

Language Server Protocol implementation written in Rust
Apache License 2.0
1k stars 55 forks source link

Update dependencies #264

Closed ralpha closed 3 years ago

ralpha commented 3 years ago

Info

This PR changes:

Because of changes in dependencies this version needs to be a minor version update, so 0.14.0. These changes where tested (and succeeded) on:

This PR has effect on other PR's and issues:

Extra info

Clippy warning was not fixed so only version updates and necessary changes are in PR.

warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
  --> tower-lsp-macros/src/lib.rs:48:1
   |
48 | fn parse_method_calls<'a>(lang_server_trait: &'a ItemTrait) -> Vec<MethodCall<'a>> {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(clippy::needless_lifetimes)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

Crate checked with:

ralpha commented 3 years ago

@ebkalderon Could you please merge this PR and publish a new version on crates.io. This way the repo is kept maintained and up to date for a bit longer, thanks.

ralpha commented 3 years ago

I updated the PR:

ralpha commented 3 years ago

Hopefully there can be a new release after this (and maybe other) PR's are merged so I can resolve other dependence conflicts in my repo downstream.

ebkalderon commented 3 years ago

Thanks for rebasing and updating the PR! Yeah, I'll be pushing a new release as soon as the backlog of other pulls requests is properly tended to.

One small matter to note, though, is that standard Rust library crates tend to usually not check in the Cargo.lock into version control. This is an intentional decision on the part of the Cargo developers. See https://github.com/rust-lang/cargo/issues/315 for the original reasoning behind this.

ralpha commented 3 years ago

One small matter to note, though, is that standard Rust library crates tend to usually not check in the Cargo.lock into version control. This is an intentional decision on the part of the Cargo developers. See rust-lang/cargo#315 for the original reasoning behind this.

Yeah you are right, did not notice/know this before, learned something :) It is also in the docs: https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html and https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

Removed the commit/lock file from the repo and history. Other changes are the same (except for lock file changes)

ebkalderon commented 3 years ago

No worries! Thanks so much for the pack of updates, and especially for updating the CHANGELOG as part of the PR. 🚀 I'll be preparing a new release to Crates.io shortly, though I might wait a bit for the author of #244 to respond before doing so, since it seems rather critical.