search

ebkalderon / tower-lsp

Language Server Protocol implementation written in Rust
Apache License 2.0
1k stars 55 forks source link

Merge changes from lspower fork #309

Closed silvanshade closed 2 years ago

silvanshade commented 2 years ago

This PR follows the discussion in #308

silvanshade commented 2 years ago

@ebkalderon I think this is ready for review. One thing to mention is that I rewrote the CI workflow based on the lspower one, which is significantly changed, although I did not include all of the changes from that yet (which include coverage and doc generation and some other things). I hope that's okay.

silvanshade commented 2 years ago

I've also included (in commit https://github.com/ebkalderon/tower-lsp/pull/309/commits/6cac1aab3ab990045987e3ff85b0dd204d4174a5) changes from this PR: https://github.com/silvanshade/lspower/pull/24

ebkalderon commented 2 years ago

Looks like the failure of cargo-audit isn't our fault. Rather, there seems to have been an actual outage of crates.io and docs.rs at the moment. I happened to notice this when navigating in my browser. :sweat_smile:

silvanshade commented 2 years ago

Thanks for the feedback! All of your suggestions seem reasonable to me. I'll make the appropriate changes.

silvanshade commented 2 years ago

@ebkalderon I believe I've addressed all of your feedback with this latest push.

silvanshade commented 2 years ago

There do still seem to be a few minor points that appear to be left somewhat unaddressed, so I outlined them in a few comments.

@ebkalderon I think these should be fixed now.

silvanshade commented 2 years ago

@ebkalderon I think the errors from the doc tests should be fixed now.

silvanshade commented 2 years ago

I've added a clippy job to the CI. I think the error is only because the clippy UI integration doesn't work coming from the forked repo but it should be fine if merged here.