search

ebkalderon / tower-lsp

Language Server Protocol implementation written in Rust
Apache License 2.0
962 stars 54 forks source link

feat(lsp-types): allow use of proposed spec types #330

Closed sno2 closed 2 years ago

sno2 commented 2 years ago

Towards #329

sno2 commented 2 years ago

I've fixed the issue and hopefully I won't get another formatting error as I ran cargo fmt before pushing.

ebkalderon commented 2 years ago

Looks like two cases of ..Default::default() in examples/tcp.rs are deemed unnecessary by Clippy, which is why CI is failing.

sno2 commented 2 years ago

Looks like two cases of ..Default::default() in examples/tcp.rs are deemed unnecessary by Clippy, which is why CI is failing.

I think that clippy isn't being run with the proposed flag which is why clippy is giving an error.

silvanshade commented 2 years ago

Going to merge this since it seems the feedback was addressed and the clippy issue was fixed. Thanks for the PR!

sno2 commented 2 years ago

@silvanshade Hey, thanks for pulling my changes. Do you know if you could push a version bump for this integration or no?

silvanshade commented 2 years ago

@sno2 I don't think I have the ability to publish a new version of the crate. @ebkalderon any thoughts on making a new release for this feature?

ebkalderon commented 2 years ago

Sure, I'm publishing the release right now! Sorry for the delay. Will reply here again once it's on Crates.io.

ebkalderon commented 2 years ago

Release v0.17.0 is now out on both GitHub and Crates.io! :tada: