ebkalderon / tower-lsp

Language Server Protocol implementation written in Rust
Apache License 2.0
962 stars 54 forks source link

switching from log facade to tracing #332

Closed attila-lin closed 2 years ago

attila-lin commented 2 years ago

fix #283

ebkalderon commented 2 years ago

This looks good to me, as an initial effort! It would be great if we could leverage the futures instrumentation facilities of tracing as well going forward. Thanks for the pull request, @attila-lin.

Would you mind fixing the conflicts in the CHANGELOG.md and Cargo.toml as a result of the recent release of 0.17.0, please?

attila-lin commented 2 years ago

Yes. I will fix it.

attila-lin commented 2 years ago

@ebkalderon done 😄

attila-lin commented 2 years ago

done. @ebkalderon

silvanshade commented 2 years ago

Thanks for the PR and for your patience getting this merged!