search

ebkalderon / tower-lsp

Language Server Protocol implementation written in Rust
Apache License 2.0
962 stars 54 forks source link

support inlineValue method and Inlay Hint Request #352

Closed OceanBelongsToMe closed 1 year ago

ebkalderon commented 1 year ago

Seems like a big omission! These should both be added for the next major release.

ebkalderon commented 1 year ago

Hmm, it seems that lsp-types still marks inlay hint requests as proposed despite being officially adopted into the spec (https://github.com/gluon-lang/lsp-types/issues/251) and also lacks support for inline values entirely (https://github.com/gluon-lang/lsp-types/issues/252). I'll have to submit a pull request against lsp-types to have this remedied before starting work on integrating this into tower-lsp.

ebkalderon commented 1 year ago

I've opened gluon-lang/lsp-types#255 to add support for this, as well as other missing functionality (except for notebook support, which seems is already being worked on by someone else).

EDIT: The pull request has finally been merged upstream! It should now be possible to update tower-lsp to lsp-types 0.94.0 and cut a new release supporting LSP 3.17 to Crates.io.

ebkalderon commented 1 year ago

Updated lsp-types to 0.94.0 in #367. Will update the LanguageServer trait to enable 3.17 features into tower-lsp soon.