search

ebkalderon / tower-lsp

Language Server Protocol implementation written in Rust
Apache License 2.0
1.02k stars 57 forks source link

Tweak grammar around "for example" #361

Closed brettcannon closed 1 year ago

brettcannon commented 1 year ago

Looks good to me! Do you think you could open a similar PR at microsoft/language-server-protocol, which is where I originally sourced this help text?

Definitely! I'm actually the dev manager for the Python experience in VS Code, so Dirk is a teammate of mine. 😁

BTW, my team is also in charge of https://github.com/microsoft/lsprotocol , so if you would ever be interested in having the LSP types auto-generated from the spec for Rust, please feel free to reach out!

brettcannon commented 1 year ago

https://github.com/microsoft/language-server-protocol/pull/1626

ebkalderon commented 1 year ago

Love this idea, @brettcannon! It would be awesome to have the protocol types generated first-party and on a regular release schedule rather than being manually updated, as with the lsp-types crate currently. I may be in touch about that.

For now, I'd be happy to merge this PR as-is. Thanks for the contribution!

brettcannon commented 1 year ago

I may be in touch about that.

Please do! We wanted to get the Python-generated types working appropriately for https://pypi.org/project/pygls/ before we reached out to anyone else, and that just got confirmed this month. So good timing on all of this. 😁

ebkalderon commented 1 year ago

@brettcannon Awesome! I'm definitely down to help build a Rust implementation, if you're still open. I reached out to you with a DM on Mastodon (@ebkalderon@hachyderm.io). Feel free to reply there so we can figure out where would be the most appropriate place online to take this conversation online!