Implement support for diagnostic requests on server

ebkalderon / tower-lsp

Language Server Protocol implementation written in Rust

Apache License 2.0

951 stars 54 forks source link

Implement support for diagnostic requests on server #374

Closed ebkalderon closed 11 months ago

ebkalderon commented 1 year ago

The LanguageServer trait is missing the following requests:

[x] textDocument/diagnostic
[x] workspace/diagnostic

The Client struct is also missing the following requests:

[x] workspace/diagnostic/refresh

These request types were added in LSP 3.17.0, but lsp-types unfortunately doesn't support them. This should have landed in lsp-types 0.94.0, but was missed in https://github.com/gluon-lang/lsp-types/pull/255. I've opened https://github.com/gluon-lang/lsp-types/pull/258 to address this omission.

ebkalderon commented 1 year ago

Unassigning myself as this ticket is blocked on https://github.com/gluon-lang/lsp-types/pull/258 currently.

meetmangukiya commented 11 months ago

does there exist any branch of tower-lsp with implementation utilizing https://github.com/gluon-lang/lsp-types/pull/258?

ebkalderon commented 11 months ago

@meetmangukiya Not at the moment, sadly. It should be pretty trivial to add after the PR is merged, though!

ebkalderon commented 11 months ago

Upstream PR was only just merged! :tada: A maintenance release of tower-lsp containing the changes should come shortly.

ebkalderon commented 11 months ago

@meetmangukiya Alright, tower-lsp 0.20.0 and tower-lsp-macros 0.9.0 have been released to crates.io. This release includes full support for diagnostic requests. :rocket:

meetmangukiya commented 11 months ago

nice, thanks!