Open Cubly opened 8 months ago
KlutzyBubbles
commented
8 months ago Added some filter tabs that could probably solve this issue. Not sure if i should submit a PR with it but thought i should put it here if any feedback is given.
https://github.com/KlutzyBubbles/r2modmanPlus/tree/modpack-filter
MythicManiac
commented
8 months ago These should probably be synced to match the definitions provided by the https://github.com/thunderstore-io/ecosystem-schema repo, which is how they're synced to the Thunderstore website. Take a look at e.g. https://github.com/thunderstore-io/ecosystem-schema/blob/master/games/data/lethal-company.yml for how they're defined and what it builds to here: https://thunderstore.io/api/experimental/schema/dev/latest/
Notably this project already has a script for syncing a copy of the latest schema to be bundled in to a build here: https://github.com/ebkr/r2modmanPlus/blob/master/scripts/sync.ts but it'd need some logic that lets it fetch a new version e.g. on launch and only use the bundled in version as a fallback.
Cubly
commented
8 months ago Added some filter tabs that could probably solve this issue. Not sure if i should submit a PR with it but thought i should put it here if any feedback is given.
https://github.com/KlutzyBubbles/r2modmanPlus/tree/modpack-filter
This is an even better solution than I had in mind. The added filter options for APIs & Libraries is also incredibly useful, as they also clog up the mods section. Nice work!
KlutzyBubbles
commented
8 months ago These should probably be synced to match the definitions provided by the https://github.com/thunderstore-io/ecosystem-schema repo, which is how they're synced to the Thunderstore website. Take a look at e.g. https://github.com/thunderstore-io/ecosystem-schema/blob/master/games/data/lethal-company.yml for how they're defined and what it builds to here: https://thunderstore.io/api/experimental/schema/dev/latest/
Notably this project already has a script for syncing a copy of the latest schema to be bundled in to a build here: https://github.com/ebkr/r2modmanPlus/blob/master/scripts/sync.ts but it'd need some logic that lets it fetch a new version e.g. on launch and only use the bundled in version as a fallback.
Did not know this was a thing, i will have a look and change up the code to make it work.
MythicManiac
commented
8 months ago If you do make it work, I'd suggest sending me a message (DM or ping) on Discord and I'll facilitate getting it merged. Integrating the tabs from the schema has been on our todo list for a while now
VaelophisNyx
commented
8 months ago Please get this to work, so sick of being forced to filter them out, preventing the use of any other filters
What problem does the feature request solve? When browsing the online section to look for mods, it is often filled with a multitude of modpacks, which is annoying when you want to browse new mods (because if you are looking for one, you are usually not looking for the other).
To remove them you have to click filter and then click mod has none of these categories, this now removes the ability to filter other actual mods, plus you have to do this everytime you use the online section.
Additional information (optional) I think some alternate tab for modpacks to be listed separate from mods would be ideal. But a show modpacks checkbox in the filter categories menu would be good enough, especially if the option you chose was persistent.