ebkr / r2modmanPlus

A simple and easy to use mod manager for several games using Thunderstore
MIT License
1.22k stars 187 forks source link

[BUG] - Mod order is lost when importing from Gale #1465

Open minimusubi opened 2 weeks ago

minimusubi commented 2 weeks ago

Describe the bug When you export a mod profile from Gale (with either a file or a code) and import it into r2modman, the custom mod sorting order is lost. This was reported as a Gale issue https://github.com/Kesomannen/gale/issues/127, but seems to be an r2modman issue.

To Reproduce

  1. Setup a mod profile in r2modman
  2. Import the mod profile from r2modman into Gale
  3. Observe that when sorting by custom order ascending, the mod list is in the same order
  4. Export the mod profile (either as file or code)
  5. Import the mod profile to r2modman
  6. Observe that when sorting by custom order standard, the mod list is no longer in the same order

Expected behavior The mod profile's custom mod order should be preserved.

Screenshots Screenshot originally posted by @Kesomannen in https://github.com/Kesomannen/gale/issues/127#issuecomment-2391584784 image On the left is the manifest that gale created, on the right the profile r2modman got from that, which is all jumbled up

Kesomannen commented 2 weeks ago

Looks like r2modman imports by the mod author's name, see https://github.com/Kesomannen/gale/issues/127#issuecomment-2394113671