ebmdatalab / openpath-dash

Experimental Dash version of openpathology browser
0 stars 1 forks source link

Changing selections sometimes leads to confusing charts #191

Open HelenCEBM opened 4 years ago

HelenCEBM commented 4 years ago

From here:

http://dash.openpathology.net/data/chart/by/practice_id/showing/ccg_id/all/lab_id/nd/numerators/HB/denominators/K/filter/all?highlight_entities=L82012&highlight_entities=L83117&highlight_entities=L83663#show-org-filter image

if you then select "compare by Test",

the heatmap is updated OK but the line chart isn't, which means:

suggestions

This kind of issue is probably inevitable to some extent in this multi-purpose tool, but we could:

sebbacon commented 4 years ago

Try it now - does it make more sense?

sebbacon commented 4 years ago

I have also tried adding the possibility of filtering to a single practice when grouping by test.

However, this needs testing - not sure it makes intuitive sense. For example it introduces a discontinuity with how you restrict to a single test (i.e. with the right hand dropdown). Let me know what you think.