ebmdatalab / outliers

repo for outlier detection work
MIT License
0 stars 0 forks source link

Review of test_outliers.py #2

Closed inglesp closed 4 years ago

inglesp commented 4 years ago

@CarolineMorton you asked me to review your test -- it all looks sensible and looks like it could pick up some bugs in the code. I'm a big fan of your approach of testing that a function works by implementing it a second way, and testing that both functions give the same result.

A couple of minor things:

CarolineMorton commented 4 years ago

hi @inglesp

thanks for this. I will make the changes in alternative_get_stats(). When you say about make_fake_data... do you want the example data set printed to the terminal or put somewhere else for example the documentation.

inglesp commented 4 years ago

I'd thought the example data could be included in the docstring for make_fake_data().