search

ebmdatalab / thedatalab

The Datalab's website
https://www.thedatalab.org
1 stars 1 forks source link

UI issues on mobile #32

Closed HelenCEBM closed 4 years ago

HelenCEBM commented 4 years ago

FYI @morleyjr @inglesp here are the issues I came across

  1. It's not clear whose site it is because our name/ logo doesn't appear at the top image

  2. The menu has two Homes image

  3. The topic-specific menu doesn't work well because you can't see all of the items, either horizontally or vertically: image

madwort commented 4 years ago

(2) and (3) seem to be fixed on the latest review site, although not (1).

morleyjr commented 4 years ago

(2) and (3) seem to be fixed on the latest review site, although not (1).

1 we decided was a bit of a faff to do and we had previously decided not to put the logo everywhere. So what I am going to do is edit the image that appears on the homepage to put our logo in the corner of it. That will solve the issue.

madwort commented 4 years ago

Hmmm, it might be tricky to edit the homepage image, because I think the crop changes as the size of the browser window changes - so there might not be a reliable corner to put it in.

morleyjr commented 4 years ago

Oh, good point. Hmm. Maybe I should put the logo in the text description? I think that should be possible.

jonny5532 commented 4 years ago

I can make it show logo on homepage on mobile as a special case, which probably solves that?

morleyjr commented 4 years ago

That would be awesome!

jonny5532 commented 4 years ago

Here: http://ebmdatalab.s2.sitereview.io/

Thoughts?

morleyjr commented 4 years ago

Looks great! Thank you so much.