Test Red thirst CDR - Githubissues

Armadk commented 2 years ago

Everything else uses base_rp_cost for the reduction. But red thirst uses actual_amount for some reason. It's even mentioned in the comments that it should be using base_rp_cost. Needs to be retested.

Armadk commented 2 years ago

// 2019-02-12: Runic Empowerment, Runic Corruption, Red Thirst and gargoyle's shadow empowerment
    // seem to be using the base cost of the ability rather than the last resource cost
    // Bug? Intended?
    // https://github.com/SimCMinMax/WoW-BugTracker/issues/396
    // https://github.com/SimCMinMax/WoW-BugTracker/issues/397

if ( actual_amount > 0 )
    {
      if ( talent.red_thirst -> ok() )
      {
        timespan_t sec = timespan_t::from_seconds( talent.red_thirst -> effectN( 1 ).base_value() / 100 ) *
          actual_amount / talent.red_thirst -> effectN( 2 ).base_value();
        cooldown.vampiric_blood -> adjust( -sec );
      }
    }

Armadk commented 2 years ago

Full testing has been completed.

Red thirst is the outlier. It uses actual RP spend for it's CDR reduction. It appears that everything else based on RP cost is done by the base cost.

Bonestorm is a bit of an exception as well, since it has variable RP cost. Actual RP cost is used for all calculations when using bonestorm.

ebonhold / simc

Test Red thirst CDR #880