10.0 Support Master list

[Armadk]

    First sketch of the new talent system.

    New player-scope options to specify the talents for the class and
    specialization trees. All options use the same format for the value: a
    '/' delimited list of <talent-name>:<talent-rank>, where <talent-rank>
    can be either a tokenized talent spell name, or a trait node entry id
    and <talent-rank> is a numeric value of the selected talent, including 0
    to indicate the talent is disabled.

    The new player scope options are:
    * class_talents -- sets the player class talent tree to this value
    * class_talents+ -- appends the value to the existing class talent tree
      of this player
    * spec_talents -- sets the player specialization talent tree to this
      value
    * spec_talents+ -- appends the value to the existing specialization
      talent tree of this player

    The option parsing happens sequentially. Talent rank values are allowed
    to be overwritten.

    The following expression changes have also been implemented:
    * talent.<talent-name>.enabled uses the new talent information
    * talent.<talent-name>.rank evaluates to the current rank of the talent

    For class modules, talents are now represented by a new wrapper object
    player_talent_t. For access, new set of player_t::find_talent_spell
    methods have been introduced to "find" talent spells based on player
    state.

    The player_talent_t wrapper object introduces two simple methods to
    access the scaling properties represented by the rank of the talent:
    * player_talent_t::base_value( effect_idx [1..N] ) returns the base
      value of the associated effect of the talent
    * player_talent_t::percent( effect_idx [1..N] ) returns the "percent
      value" of the associated effect of the talent

[Armadk]

• [ ] Pillar of frost rank 2 remove. Base pillar is now 20%
• [ ] Ensure razor ice whitelist covers all possible spells
• [ ] Verify Frost Mastery list. For example it was missing Soul Reaper in the first version of the dump
• [ ] rage of the frozen champion legendary gets a new spell id for the trait node. Verify functionality
• [ ] unholy blight no longer affects guardians with the damage amp. It was changed to player. So it's now player + pet.
• [ ] Verify all castable spells are included in the hasted GCD spec aura
• [ ] bdk aura death strike aura damage nerf
• [ ] bdk aura veteran of the third war no longer gets an extra bonus to health
• [ ] bdk aura death and decay damage nerf
• [ ] Icy talons is now 2% per stack. Spell data was complete rearranged. Needs to be redone in simc.
• [ ] death's caress now gives 2 (s3) bone shield charges
• [ ] red thirst spelldata reworked to now use a proper time value. Needs an update so it doesn't call base_value()
• [ ] unholy assault goes to 90 sec cd, from 75
• [ ] heartbreaker now has ranks. 1 rp per rank, with 2 ranks
• [ ] apoc is single rank. Runes should be part of the base now.
• [ ] brittle needs to be checked to see what diseases can trigger it
• [ ] brittle whitelist needs to be checked to make sure it has all damage sources
• [ ] tightening grasp in blood spec tree needs to be checked to ensure it affects all possible damage sources
• [ ] improved frost strike added
• [ ] improved rime added
• [ ] cleaving strikes talent for determining chain targets for hs, ss, or oblit
• [ ] improved vampiric blood talent. Replaces vamp blood rank2
• [ ] improved obliterate
• [ ] examine might of the frozen wastes. Tooltip says all crits generate KM. Check if this applies to DW as well.
• [ ] Soul reaper is now shadowfrost damage
• [ ] merciless strikes - increased crit chance node
• [ ] acclimation - reduced icebound fortitude cd
• [ ] proliferating chill - chains hits a second target. Check for cold heart interaction
• [ ] blood scent - increased leech
• [ ] suppression - increased avoidance
• [ ] might of thassarian - increased primary stat %
• [ ] unholy bond - boost runeforges
• [ ] unholy ground - increased haste when in dnd
• [ ] improved death strike - very different between blood and the dps specs
• [ ] assimilation - grants RP based on AMZ absorb amount
• [ ] brittle - 15% chance for disease to trigger debuff. Need to verify which diseases. Also verify whitelist. Affects guardians
• [ ] rune mastery - str buff
• [ ] blood draw - falling below % health causes you to drain health from nearby enemies
• [ ] improved bone shield - flat haste buff
• [ ] improved heart strike - damage buff
• [ ] blood fortification - increased stam, and decreased damage taken
• [ ] reinforced bones - increased armor from Bone shield
• [ ] hasty bargain - haste increased when you consume crimson scourge
• [ ] runic command - increased max runic
• [ ] unleashed frenzy - frost strike increases str
• [ ] everfrost - similar to conduit
• [ ] absolute zero - reduced frostwyrms cd
• [ ] biting cold - similar to conduit
• [ ] frigid executioner - increased oblit dam and chance to refund runes. Similar to kolitras legendary
• [ ] rage of the frozen champion - reimplementation of legendary effect
• [ ] cold blooded rage - frost strike crits has a chance to grant KM
• [ ] invigorating freeze - Frost fever crits increase rp gain chance
• [ ] bonegrinder - increased crit chance on km. other stuff
• [ ] enduring strength - increased str after pillar ends
• [ ] frostwhelp's aid - on whelp hits boosts mastery
• [ ] piercing chill - ramping chill streak debuff
• [ ] enduring chill - chance to increase chill streak max bounces
• [ ] unholy aura - boosted minion damage
• [ ] reaping - boost damage in execute range
• [ ] death rot - dc boosts shadow dam
• [ ] improved death coil - increased DC dam. Hits an additional target.
• [ ] replenishing wounds - when wounds pop, generate additional rp
• [ ] ghoulish frenzy - boosts damage of you and your pet
• [ ] festermight - basically bfa azerite trait
• [ ] morbidity - boosts damage per disease. Current whitelist is VP, unholy blight, and festering wound
• [ ] leeching strike - hs heals
• [ ] insatiable blade - similar to CRW legendary
• [ ] shattering bone - when BS charge is consumed, do aoe damage. Triple damage if standing in dnd
• [ ] heartrend - chance to increase damage of next death strike
• [ ] everlasting bond - similar to T28 set for blood. Extends DRW duration. Add a DRW
• [ ] anticipation - spirit drain conduit basically
• [ ] abom limb

[Armadk]

Basic plan

• [ ] Cleanup Slands
  • [ ] Delete t28 tier set
  • [ ] Remove legendaries ( keep some code for new spells )
  • [ ] Remove conduits ( keep some code for new spells )
• [ ] Implement all Class talents
• [ ] Implement Frost talents
• [ ] Implement Unholy talents
• [ ] Implement Blood talents

[Armadk]

Things to check as they were marked NYI in simc

• [ ] Will of the Necropolis
• [ ] Death Pact
• [ ] Purgatory

[Armadk]

Blood tree Blood Fortification looks like it's intended to be a replacement for Veteran of the third war rank 2

• R2 = 30% health, 10% DR Unfortunately only one thing can be scaled with multi rank talents. So currently blood fortification only gives 30% increased health, but 3% DR.
• Rune tap is missing rank2 for the second charge
• Verify improved heart strike boosts DRW hs damage
• Heart Strike Rank2 is missing for the extra 5 rp gain

[Armadk]

Unholy tree

• Dark transformation has no rank2, so ghould is not gaining 100 energy on use
• Check festering strike rank 2. Original version only affected wounds via spelldata, but the new one has both strike, and wounds flagged.
• Scourge strike dnd cleave may be broken. Spell data is a little messed up for it.

[Armadk]

From Navv ok, pushed the changes you should be able to now do just talent->effectN( x ) and all is well in the world as if nothing ever changed

So we can ditch a lot of the spell() -> effectN () calls

[Armadk]

implemented