search

ebonhold / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
0 stars 0 forks source link

Base cost for RP gains seem to have changed #891

Closed Armadk closed 11 months ago

Armadk commented 2 years ago

Based on feedback from Kyrasis, the way that base_cost for RP gains has changed.

Some baseline info: DS is 45 rp cost Imp ds reduces cost by 5 rp = 40 cost - red thirst gets 45 benefit Ossuary reduces cost by 5 rp = 35 cost - red thirst gets 40 benefit

For whatever reason, for the purposes of red thirst if you have imp ds talented, it will give reduction to 40 rp cost, but you get gains as if it cost 45 rp.

However if you have only ossuary talented, you get rp spend

Armadk commented 2 years ago

This was previously tested in #880 and at the time, actual RP spend seemed to be used. So for some reason, the aura talent does not seem to be applying in the case of red thirst. Only ossuary.

Armadk commented 11 months ago

Finally fixed this bug along with the t31 tier set changes