Prot Warrior work

[Armadk]

• [x] talents.protection.ignore_pain = find_talent_spell( talent_tree::SPECIALIZATION, "Ignore Pain" );

• [x] talents.protection.revenge = find_talent_spell( talent_tree::SPECIALIZATION, "Revenge" );

• [x] talents.protection.demoralizing_shout = find_talent_spell( talent_tree::SPECIALIZATION, "Demoralizing Shout" );

• [x] talents.protection.devastator = find_talent_spell( talent_tree::SPECIALIZATION, "Devastator" );

• [x] talents.protection.last_stand = find_talent_spell( talent_tree::SPECIALIZATION, "Last Stand" );

• [x] talents.protection.improved_heroic_throw = find_talent_spell( talent_tree::SPECIALIZATION, "Improved Heroic Throw" );

• [x] talents.protection.best_served_cold = find_talent_spell( talent_tree::SPECIALIZATION, "Best Served Cold" );

• [x] talents.protection.strategist = find_talent_spell( talent_tree::SPECIALIZATION, "Strategist" );

• [x] talents.protection.brace_for_impact = find_talent_spell( talent_tree::SPECIALIZATION, "Brace for Impact" );

• [x] talents.protection.unnerving_focus = find_talent_spell( talent_tree::SPECIALIZATION, "Unnerving Focus" );

• [x] talents.protection.challenging_shout = find_talent_spell( talent_tree::SPECIALIZATION, "Challenging Shout" );

• [x] talents.protection.instigate = find_talent_spell( talent_tree::SPECIALIZATION, "Instigate" );

• [x] talents.protection.rend = find_talent_spell( talent_tree::SPECIALIZATION, "Rend", WARRIOR_PROTECTION );

• [x] talents.protection.bloodsurge = find_talent_spell( talent_tree::SPECIALIZATION, "Bloodsurge", WARRIOR_PROTECTION );

• [ ] talents.protection.fueled_by_violence = find_talent_spell( talent_tree::SPECIALIZATION, "Fueled by Violence", WARRIOR_PROTECTION );

• [ ] talents.protection.brutal_vitality = find_talent_spell( talent_tree::SPECIALIZATION, "Brutal Vitality" );

• [ ] talents.protection.disrupting_shout = find_talent_spell( talent_tree::SPECIALIZATION, "Disrupting Shout" );

• [x] talents.protection.show_of_force = find_talent_spell( talent_tree::SPECIALIZATION, "Show of Force" );

• [x] talents.protection.sudden_death = find_talent_spell( talent_tree::SPECIALIZATION, "Sudden Death", WARRIOR_PROTECTION );

• [x] talents.protection.thunderlord = find_talent_spell( talent_tree::SPECIALIZATION, "Thunderlord" );

• [x] talents.protection.shield_wall = find_talent_spell( talent_tree::SPECIALIZATION, "Shield Wall" );

• [x] talents.protection.bolster = find_talent_spell( talent_tree::SPECIALIZATION, "Bolster" );

• [x] talents.protection.tough_as_nails = find_talent_spell( talent_tree::SPECIALIZATION, "Tough as Nails" );

• [ ] talents.protection.spell_block = find_talent_spell( talent_tree::SPECIALIZATION, "Spell Block" );

• [x] talents.protection.bloodborne = find_talent_spell( talent_tree::SPECIALIZATION, "Bloodborne", WARRIOR_PROTECTION );

• [x] talents.protection.heavy_repercussions = find_talent_spell( talent_tree::SPECIALIZATION, "Heavy Repercussions" );

• [x] talents.protection.into_the_fray = find_talent_spell( talent_tree::SPECIALIZATION, "Into the Fray" );

• [x] talents.protection.enduring_defenses = find_talent_spell( talent_tree::SPECIALIZATION, "Enduring Defenses" );

• [x] talents.protection.massacre = find_talent_spell( talent_tree::SPECIALIZATION, "Massacre", WARRIOR_PROTECTION );

• [x] talents.protection.anger_management = find_talent_spell( talent_tree::SPECIALIZATION, "Anger Management" );

• [x] talents.protection.defenders_aegis = find_talent_spell( talent_tree::SPECIALIZATION, "Defender's Aegis" );

• [x] talents.protection.impenetrable_wall = find_talent_spell( talent_tree::SPECIALIZATION, "Impenetrable Wall" );

• [x] talents.protection.punish = find_talent_spell( talent_tree::SPECIALIZATION, "Punish" );

• [x] talents.protection.juggernaut = find_talent_spell( talent_tree::SPECIALIZATION, "Juggernaut", WARRIOR_PROTECTION );

• [x] talents.protection.focused_vigor = find_talent_spell( talent_tree::SPECIALIZATION, "Focused Vigor" );

• [x] talents.protection.shield_specialization = find_talent_spell( talent_tree::SPECIALIZATION, "Shield Specialization" );

• [x] talents.protection.enduring_alacrity = find_talent_spell( talent_tree::SPECIALIZATION, "Enduring Alacrity" );

• [x] talents.protection.shield_charge = find_talent_spell( talent_tree::SPECIALIZATION, "Shield Charge" );

• [x] talents.protection.booming_voice = find_talent_spell( talent_tree::SPECIALIZATION, "Booming Voice" );

• [ ] talents.protection.indomitable = find_talent_spell( talent_tree::SPECIALIZATION, "Indomitable" );

• [x] talents.protection.violent_outburst = find_talent_spell( talent_tree::SPECIALIZATION, "Violent Outburst" );

• [x] talents.protection.ravager = find_talent_spell( talent_tree::SPECIALIZATION, "Ravager", WARRIOR_PROTECTION );

• [x] talents.protection.battering_ram = find_talent_spell( talent_tree::SPECIALIZATION, "Battering Ram" );

• [x] talents.protection.champions_bulwark = find_talent_spell( talent_tree::SPECIALIZATION, "Champion's Bulwark" );

• [ ] talents.protection.battle_scarred_veteran = find_talent_spell( talent_tree::SPECIALIZATION, "Battle-Scarred Veteran" );

• [x] talents.protection.dance_of_death = find_talent_spell( talent_tree::SPECIALIZATION, "Dance of Death", WARRIOR_PROTECTION );

• [x] talents.protection.storm_of_steel = find_talent_spell( talent_tree::SPECIALIZATION, "Storm of Steel", WARRIOR_PROTECTION );

[Armadk]

Kill me

[Armadk]

This is only a first pass. No real effort has been made to make sure these work exactly.

[Armadk]

Add a proc for devastator shield slam reset add a proc for strategist shield slam resets

[Armadk]

had to add improved_heroic_throw, new talent

[Armadk]

Do abilities have to hit for shield slam to reset????

[Armadk]

Re-test brace for impact. enough has changed that it needs a full work up.

Rework completed

[Armadk]

Unnerving focus whitelist needs validation. I don't think this actually affects all abilities currently.

[Armadk]

Rend is an absolute shit show. It references a prot version for the damage values, however, it triggers the arms version, which does higher damage. Ping in tt for what the fuck to do about it.

[Armadk]

Verify that bolster extends duration when shield block is already up, and doesn't just set duration to last stand duration.

[Armadk]

unnerving focus also seems to do 60%, even though tooltip says 50%

[Armadk]

From Nomeratur:

Warrior Bugs

• Thunderclap consumes Seeing Red at 7 stacks without benefitting off of Outburst
• Brutal Vitality stops working once you cap Ignore Pain, only starts working again once IP falls off
• Avatar applies Unbreakable Will when you have Immovable Object talented The TC bug only exists on retail not on beta anymore Ravager when talented with dance of death also doesn't gain 1 additional tick from the 2sec increase, remains at 6 ticks But at this point I see that as a feature, it's existed since day1 Ravager also only ticks 5 times when not sent out in melee range But that doesn't really matter for simc

[Armadk]

From: Mythie. Regarding armor and str interaction with each other

so, AttT and Vigor in this version work as they did previously (what is colloquially called loop) in addition Reinforced Plates is now broken and applies not just to base armor but also to the armor gained from strength and AttT so you get https://www.desmos.com/calculator/oekaehqur0, you'll need to input raw values of strength and armor in [base stats]

[Armadk]

For Later: Mostly Defensive talents

• Battle Scarred Veteran
• Indomitable
• Brutal Vitality
• Indomitable
• Spell Block

Utility

• Disrupting Shout

Implement Battle Scarred Veteran later. It's an intersting talent. not worth doing atm.

[Armadk]

First pass on the spec talents is complete.