ebonhold / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
0 stars 0 forks source link

Redo entire rage system #944

Open Armadk opened 8 months ago

Armadk commented 8 months ago

Best I can tell at current it is not wrong, however, things should get a re-write.

Some observations.

Recklessness is currently boosting rage gain for all things, while the spell actually operates on a whitelist, and boosts the value within the spell. We should fix this at the very least.

Due to how we track things, some rage gains were seperated out into different procs. We should re-evaluate these, and fix and update things as necessary