search

ebonhold / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
0 stars 0 forks source link

Blademaster's Torment has a TODO, needs to be done for avatar effect 8 #969

Closed Armadk closed 1 week ago

Armadk commented 2 weeks ago

Add Flat Modifier (107): Spell Cooldown (11) is currently unsupported in parse_effects.

Blademaster's is code complete, however, for the temporary cdr to apply during avatar being up, we need to add support for flat mod spell cooldown in parse_effects.

Armadk commented 2 weeks ago

It should be noted, there looks like there is a number of warrior spells that use flat mod spell cooldown, though I think they all currently get picked up apply_affecting_aura, as I couldn't find another that was a temporary reduction, based on a buff.

Armadk commented 1 week ago

Not going to bother, did it the old way for now