search

ebook-utils / css-parser

CSS related utilities (parsing, serialization, etc) for python
GNU Lesser General Public License v3.0
31 stars 5 forks source link

Publish on PyPI #1

Closed kovidgoyal closed 5 years ago

kovidgoyal commented 5 years ago

This issue is to track progress with publishing css-parser on pypi. Once all maintainers feel we are ready to make a release, I propose bumping the version number and releasing on PyPI. Unless someone else wants to do it, I will be happy to make the release/publish under my account on PyPI.

kevinhendricks commented 5 years ago

I think the current state fixes all known issues we had with cssutils. That said, there are other more rarely used at-rules such as @supports that I have seen in real ebooks that we should eventually add support for.

So I am okay with bumping the version number (I did that once but even resetting the numbering wouldn't hurt), and starting the process to release/publish css-parser under your account on PyPi.

Sigil is going to embed this css-parser into our plugin library for the next couple releases so timing of when to publish on PyPi is not critical to us.

wrCisco commented 5 years ago

I forgot to write the inline documentation of the two new prefs in the serializer (I can do it right now), and we can also add Kovid's patch to avoid shifting of multiline comments inside rules's declarations (I'd just un-tab of one level the 'out.append(separator)' line, out of the else block).

Other than that I'm OK with the publication.

kevinhendricks commented 5 years ago

Sounds good to me. Once you get those changes in place, please let everyone know, and Sigil will pull the first version to include into its next release so Sigil can work on fixing the css reformatting issue and close it.

wrCisco commented 5 years ago

Ok, I added both.

kovidgoyal commented 5 years ago

I have updated setup.py, to change project name, author, urls etc. Please review and let me know if you are all ok with it. Then I will go ahead and bump the version and publish.

wrCisco commented 5 years ago

OK for me.

kevinhendricks commented 5 years ago

Looks good to me too.

Sent from my iPhone

On Jan 1, 2019, at 11:51 PM, Kovid Goyal notifications@github.com wrote:

I have updated setup.py, to change project name, author, urls etc. Please review and let me know if you are all ok with it. Then I will go ahead and bump the version and publish.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

dougmassay commented 5 years ago

Not a big deal at all in terms of publishing, but I noticed the status badge for AppVeyor in the README is showing as "unknown," even though the last checks show everything passed.

kovidgoyal commented 5 years ago

that's just an artifact of github caching, it will hopefully get updated eventually

kovidgoyal commented 5 years ago

published at: https://pypi.org/project/css-parser/

I dont use pypi myself, so if there are any issues with the upload, let me know and I will fix them.

wrCisco commented 5 years ago

I just tried it, installation went smoothly. The badges in the project description aren't displayed correctly, though (two links attached together, it seems).

kovidgoyal commented 5 years ago

Feel free to correct the links.

wrCisco commented 5 years ago

I'm not sure how: the links are fine here on github, only on PyPI they got merged.

dougmassay commented 5 years ago

I think PyPI's a little pickier about the Markdown that works in its descriptions. I'd probably just strip the badges out of the readme/description before publishing next time.

wrCisco commented 5 years ago

I just added long_description_content_type='text/markdown' in setup.py (I'm not sure that solves the issue, but I think it's harmless to try).

kovidgoyal commented 5 years ago

Good find, as far as I can tell, it should fix it. We will know after the next release.