search

ebook-utils / css-parser

CSS related utilities (parsing, serialization, etc) for python
GNU Lesser General Public License v3.0
31 stars 5 forks source link

Please add support for Python 3.10 #10

Closed sten0 closed 2 years ago

sten0 commented 2 years ago

Hi @kovidgoyal,

Debian has begun its Python 3.9 to 3.10 migration; however, css-parser is unfortunately not ready for 3.10. More information can be found at Bug #1001419 python-css-parser: (autopkgtest) needs update for python3.10: Right exception, wrong message: got 'can't set attribute 'literalname'' instead of 'can't set attribute'. I am of course happy to test a prerelease or to cherry pick the fix.

Kind regards, Nicholas

kevinhendricks commented 2 years ago

See https://github.com/ebook-utils/css-parser/commit/6b5e22217d69fbe4afe17f614af663af66de284f

Doesn't this change from 11 months ago already address your issue?

sten0 commented 2 years ago

Kevin Hendricks @.***> writes:

See https://github.com/ebook-utils/css-parser/commit/6b5e22217d69fbe4afe17f614af663af66de284f

Thank you, yes, this commit appears to address the issue. Sorry for my laziness/exhaustion; I had assumed that a stable css-parser release would have been made in November or December so that PyPI users could benefit from Python 3.10 support. Cherry picking this commit now for the Debian package.

Would you like me to test HEAD as well, or is it not ready yet?

kovidgoyal commented 2 years ago

I just released 1.0.7 use that.

sten0 commented 2 years ago

Kovid Goyal @.***> writes:

I just released 1.0.7 use that.

Thanks :-) Updating to 1.0.7 (from 1.0.6 plus cherry picked commits) now!