search

ebook-utils / css-parser

CSS related utilities (parsing, serialization, etc) for python
GNU Lesser General Public License v3.0
31 stars 5 forks source link

Replace non-standard own-made assert methods by the standard ones #12

Closed mcepl closed 2 years ago

mcepl commented 2 years ago

There is no need to replicate badly assert methods which are already in the standard library.

kovidgoyal commented 2 years ago

I would imagine that the original author of cssutils used these because at the time the equivalent functionality didnt exist in the stdlib.

kovidgoyal commented 2 years ago

And you will need to re-implement them for python 2 yourself since css-parser still supports py2, maybe you will do a better job than the original developer.

mcepl commented 2 years ago

I would imagine that the original author of cssutils used these because at the time the equivalent functionality didnt exist in the stdlib.

Yes, but even if I imagine that you support 2.7 (and by the way, seriously, why?) then it is certainly not necessary to have a code to support 2.4 (which I found in places).

OK, I will add some 2.* code (seriously, why?).

kovidgoyal commented 2 years ago

On Tue, Jan 25, 2022 at 11:47:19PM -0800, Matěj Cepl wrote:

I would imagine that the original author of cssutils used these because at the time the equivalent functionality didnt exist in the stdlib.

Yes, but even if I imagine that you support 2.7 (and by the way, seriously, why?) then it is certainly not necessary to have a code to support 2.4 (which I found in places).

OK, I will add some 2.* code (seriously, why?).

because I dont drop support for things for no good reason (seriously, why wouldanyone consider that a good idea?)

mcepl commented 2 years ago

because I dont drop support for things for no good reason (seriously, why wouldanyone consider that a good idea?)

Because your programs will become unmaintainable mess? How is your support for Python 1.5 going?

kovidgoyal commented 2 years ago

On Wed, Jan 26, 2022 at 12:52:51AM -0800, Matěj Cepl wrote:

because I dont drop support for things for no good reason (seriously, why wouldanyone consider that a good idea?)

Because your programs will become unmaintainable mess? How is your support for Python 1.5 going?

I've been maintaining software for 25 years none of it has yet become an unmaintainable mess, so I think I'll stick with the existing code, thanks.

mcepl commented 2 years ago

I've been maintaining software for 25 years none of it has yet become an unmaintainable mess, so I think I'll stick with the existing code, thanks.

Why did you close it, please? I have provided your py2k compatibility fixes (not that I agree with the idea, but it is your project).

kovidgoyal commented 2 years ago

Because given your attitude I dont feel like spending my valuable time reviewing this

kovidgoyal commented 2 years ago

Arrah patsy mind the baby, arrah patsy mind th echild, he'll kick and bite and cry all night.