search

ebook-utils / css-parser

CSS related utilities (parsing, serialization, etc) for python
GNU Lesser General Public License v3.0
31 stars 5 forks source link

Add testsuite to the dist tarball. #2

Closed eli-schwartz closed 5 years ago

eli-schwartz commented 5 years ago

Was sort of excited to see this revamped module, and started packaging it so I could use it for the new calibre release. But I also wanted to run the testsuite...

kovidgoyal commented 5 years ago

I deliberately left out the test suite. css-parser does not interact with the environment and is tested under continuous integrations, so i dont really see the point in including the test suite.

eli-schwartz commented 5 years ago

I'm not sure what interacting with the environment has to do with anything, but I can think of cases where e.g. a python module did some odd things on python3.7, only when using the $SOURCE_DATE_EPOCH variable for reproducible builds, with nothing other than the interpreter itself to interact with.

Generally speaking, I see no reason not to include tests, and it's standard operating procedure to run testsuites whenever possible when doing Arch Linux packaging.

kovidgoyal commented 5 years ago

OK, I dont really care either way -- it's just a few wasted bytes/CPU cycles to run these tests at build time on Linux distros, I guess.