search

ebourg / jsign

Java implementation of Microsoft Authenticode for signing Windows executables, installers & scripts
https://ebourg.github.io/jsign
Apache License 2.0
250 stars 107 forks source link

Improve MAVEN build Performance #102

Closed ChenZhangg closed 1 year ago

ChenZhangg commented 2 years ago

Parallel builds in Maven 3 Maven 3.x has the capability to perform parallel builds.

Apache Maven Dependency Plugin can be used to find unused dependencies. And I found following list. Maybe we can remove them. jsign-parent jsign-core {groupId='org.mockito', artifactId='mockito-all'} jsign-ant jsign-cli {groupId='org.mockito', artifactId='mockito-all'} jsign {groupId='net.jsign', artifactId='jsign-core'} {groupId='junit', artifactId='junit'} {groupId='org.mockito', artifactId='mockito-all'} jsign-maven-plugin {groupId='org.apache.maven', artifactId='maven-core'} {groupId='org.apache.maven.plugin-testing', artifactId='maven-plugin-testing-harness'} {groupId='org.apache.maven', artifactId='maven-compat'} jsign-gradle-plugin {groupId='org.gradle', artifactId='gradle-native'} {groupId='org.gradle', artifactId='gradle-process-services'}

According to Maven parallel test, we can run tests in parallel.

===================== If there are any inappropriate modifications in this PR, please give me a reply and I will change them.

ebourg commented 2 years ago

Thank you for the suggestion. How much build time did you gain with these changes?

ChenZhangg commented 2 years ago

I found the travis build was broken. Maybe some deleted dependencies are needed. As Apache Maven Dependency Plugin is not accurate when encounter something like reflection.

ebourg commented 1 year ago

I don't think I'll apply this change, build log linearity and clarity is more important than speed. When something breaks I prefer not deciphering entangled and unrelated build messages. Thank you again for the suggestion.