ebourg / jsign

Java implementation of Microsoft Authenticode for signing Windows executables, installers & scripts
https://ebourg.github.io/jsign
Apache License 2.0
250 stars 107 forks source link

Query IMDSv2 on AWS EC2 to get credentials for KMS if no storepass parameter #152

Closed vmal-altium closed 1 year ago

vmal-altium commented 1 year ago

This is a solution for #147.

Note

If running from within a container hosted on that EC2, the IMDSv2 may not be reachable by default (hop limit set to 1 for the PUT request to obtain the API token). Updating the hop limit to 2 solves the issue, but this is not managed here. Just a clue in case of breaking tests.

ebourg commented 1 year ago

Thank you for the great PR, comments inline.

ebourg commented 1 year ago

PR merged, thank you!